Allow 2d input if RNN order is BatchLastIndex #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot remove RNN error check test, will fix it tomorrow |
|
We should add a check comparing the results for a matrix input and a 3d Array input with a single batch dimension, to verify that the current impl is doing the right thing. |
avik-pal
reviewed
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 95.98% 91.25% -4.73%
==========================================
Files 55 55
Lines 2813 2814 +1
==========================================
- Hits 2700 2568 -132
- Misses 113 246 +133 ☔ View full report in Codecov by Sentry. |
avik-pal
reviewed
Jul 18, 2024
avik-pal
reviewed
Jul 18, 2024
avik-pal
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #767